Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vpc branch merge #1482

Open
wants to merge 214 commits into
base: master
Choose a base branch
from
Open

Vpc branch merge #1482

wants to merge 214 commits into from

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Dec 16, 2024

This merges VPC related work that was developed under vpc-feature-branch back to master

annakhm and others added 30 commits July 11, 2024 00:43
@annakhm
Baseline for VPC2.0
6f8a9b1 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Revise GitHub actions files to run on feature branches
25d8f8d 
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Merge pull request #1260 from ksamoray/f-github-actions
ed2e296 
Revise GitHub actions files to run on feature branches
@annakhm
Switch to updated temporary SDK
d735338 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Fix VPC documentation with correct DS name
a505650 
nsxt_policy_vpc datasource has been renamed to nsxt_vpc

Signed-off-by: Kobi Samoray <[email protected]>
@annakhm
Merge pull request #1269 from vmware/sdk-midjuly
5d98d70 
Switch to updated temporary SDK
@ksamoray
Merge pull request #1271 from ksamoray/vpc_r_docfix
3b25446 
Fix VPC documentation with correct DS name
@ksamoray
Fix failing tests on vpc20 branch
b7a2f96 
VPC datasource test is failing as the context block shouldn't have the VPC itself

Signed-off-by: Kobi Samoray <[email protected]>
@annakhm
Add length validation to display name and desc
8b13758 
This would apply to all resources that inherit from
ManagedResource object. Length limits are taked from NSX
spec and are enforced by NSX, hence we're not breaking
backwards compatibility for valid terraform configs.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Merge pull request #1278 from ksamoray/vpc-testfix
e22edab 
Fix failing tests on vpc20 branch
@ksamoray
GatewayConnection autogenerated files
edaa039 
Generated with command line params below:
GatewayConnection --no-api-wrapper

Signed-off-by: Kobi Samoray <[email protected]>
@annakhm
Add new member types to group criteria
a02a019 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Manual edits for GatewayConnection
61dbcf3 
Signed-off-by: Kobi Samoray <[email protected]>
@annakhm
Add VPC group data source
5236c1d 
Test for this data source is covered together with VPC group
resource test.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Merge pull request #1259 from ksamoray/gateway-connection
c07330b 
Gateway connection resource for VPC v2.0
@annakhm
Merge pull request #1285 from vmware/add-member-type
e2fee37 
Add new member types to group criteria
@annakhm
Merge pull request #1289 from vmware/vpc-group-data
dbd0a9b 
Add VPC group data source
@ksamoray
Fix nsxt_vpc_group datasource documentation
6620922 
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Add id field validator and apply to context ids
b42a2d0 
To avoid entry of invalid ids to the context fields.

Signed-off-by: Kobi Samoray <[email protected]>
@annakhm
VPC 2.0 Service Profile support
8b44c1b 
Extended tests will be added as follow up

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1286 from vmware/vpc20-service-profile2
2b392c7 
Vpc20 service profile support
@annakhm
Update temporary SDK
9c0c170 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@ksamoray
Merge pull request #1295 from vmware/update-temp-sdk
edbba49 
Update temporary SDK
@ksamoray
Merge pull request #1292 from ksamoray/ds_vpc_group_docfix
70ce9bc 
Fix nsxt_vpc_group datasource documentation
@ksamoray
Merge pull request #1293 from ksamoray/id-validator-cp
7fe2676 
Add id field validator and apply to context ids
@ksamoray
Fix VPC datasource doc category
10341d3 
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Update GatewayConnection to latest schema
54a0613 
Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Merge pull request #1298 from ksamoray/vpc-doc-category
0359ea0 
Fix VPC datasource doc category
@annakhm
Fixes in VPC documentation
5d14135 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1302 from vmware/fix-vpc-docs
b083e45 
Fixes in VPC documentation
salv-orlando and others added 18 commits October 21, 2024 11:10
@salv-orlando
Merge pull request #1434 from vmware/remove-ip-blocks
91df0f2 
Remove IP blocks from connectivity profiles NAT
@annakhm
Remove redundant context attr from tgw attachment
2c17a61 
In addition, refine documentaion for this resource

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Clarify VPC group documentation
4074e35 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1443 from vmware/remove-context-from-tgwa
0eb8cad 
Remove context from transit gateway attachment resource
@annakhm
Merge pull request #1444 from vmware/vpc-group-docs
d6cdf56 
Clarify VPC group documentation
@ksamoray
Handle default_security_profile attribute in project read func
9ea081c 
nsxt_policy_project has a default_security_profile attribute but it was not handled correctly in read operation.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Merge pull request #1457 from ksamoray/default_security_profile_fix
59391db 
Handle default_security_profile attribute in project read func
@annakhm
Add VPC attachment resource
066ad49 
This is the new way of attaching connectivity profile to vpc,
hence the profile attribute is also removed from vpc resource

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1464 from vmware/vpc-attachment-resource
8aa682d 
Add VPC attachment resource
@ksamoray
Handle project path parsing properly
d8910a4 
Path parsing func parseStandardPolicyPath() didn't handle well project paths, seems like it could only handle sub-project objects.

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray
Merge pull request #1467 from ksamoray/policy_path_parse_err
0cc3fe1 
Handle project path parsing properly
@annakhm
Adjust to DHCP changes in service and subnet
04283e3 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1466 from vmware/dhcp-changes
10df7e1 
Adjust to DHCP changes in service and subnet
@annakhm
Fix formatting
53d8516 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1472 from vmware/fix-fmt
68e74c2 
Fix formatting
@annakhm
Allow updating vpc and project IP allocation
c5b171f 
This follows fix on NSX

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm
Merge pull request #1477 from vmware/fix-vpc-ip-allocation
2413c69 
Allow updating IP allocation under project or VPC
@annakhm
Merge branch 'vpc20-feature-branch'
cab9073 
Signed-off-by: Anna Khmelnitsky <[email protected]>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 16, 2024
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@ksamoray
Fix policy importer helper to handle non-path parameter
40ee24f 
This has been broken, as the importer helper did not return the schema when it was detected that the parameter isn't a policy path.

Signed-off-by: Kobi Samoray <[email protected]>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@annakhm @ksamoray
Add vc_folder flag to project definition.
9d99e4c 
This is relevant for NSX 9.0.0 onwards.
In addition, mark `default_security_profile` as Computed to
avoid non-empty diff.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksamoray ksamoray Awaiting requested review from ksamoray

@salv-orlando salv-orlando Awaiting requested review from salv-orlando

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dco-required DCO Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annakhm @vmwclabot @ksamoray @salv-orlando