Implement host transport node collection resource #965
Conversation
ksamoray
force-pushed
the
host_transport_node_collection
branch
8 times, most recently
from
18c5454 to
a8d27e4
Compare
ksamoray
changed the title
ksamoray
force-pushed
the
host_transport_node_collection
branch
2 times, most recently
from
de0f64c to
b7a0a38
Compare
| "transport_node_profile_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Transport Node Profile Path", |
There was a problem hiding this comment.
This is a path - as this is a policy resource, it requires paths as object references. I followed the API naming where this attribute is called transport_node_profile_id but maybe it makes more sense to name it transport_node_profile_path.
ksamoray
force-pushed
the
host_transport_node_collection
branch
3 times, most recently
from
21cd5ee to
8d994e8
Compare
| resource "nsxt_policy_host_transport_node_collection" "htnc1" { | ||
| display_name = "HostTransportNodeCollection1" | ||
| compute_collection_id = data.vsphere_compute_cluster.compute_cluster.id | ||
| transport_node_profile_path = nsxt_policy_host_transport_node_profile.tnp.id |
There was a problem hiding this comment.
shouldn't this be nsxt_policy_host_transport_node_profile.tnp.path?
ksamoray
force-pushed
the
host_transport_node_collection
branch
4 times, most recently
from
9e1ba7f to
952b07e
Compare
|
/test-all |
1 similar comment
|
/test-all |
ksamoray
force-pushed
the
host_transport_node_collection
branch
from
952b07e to
04ff267
Compare
|
/test-all |
ksamoray
force-pushed
the
host_transport_node_collection
branch
3 times, most recently
from
090e0fe to
49512a2
Compare
| "tag": getTagsSchema(), | ||
| "site_path": { | ||
| Type: schema.TypeString, | ||
| Description: "Path to the site this Transport Zone belongs to", |
There was a problem hiding this comment.
Transport Zone => resource ?
| }, | ||
| "enforcement_point": { | ||
| Type: schema.TypeString, | ||
| Description: "ID of the enforcement point this Transport Zone belongs to", |
There was a problem hiding this comment.
Transport Zone => resource ?
| Update: resourceNsxtPolicyHostTransportNodeCollectionUpdate, | ||
| Delete: resourceNsxtPolicyHostTransportNodeCollectionDelete, | ||
| Importer: &schema.ResourceImporter{ | ||
| State: nsxtPolicyPathResourceImporter, |
There was a problem hiding this comment.
I don't think this can work out of the box here, since enforcement point and site need to be set before Read is called?
|
Is it too complex to add a test for this? perhaps with env variable indicating VC compute ID? |
It means that we'll need a cluster on VC which isn't configured with NSX. We can create such with the LM topology but it'll require an additional ESXi node per topology. |
ksamoray
force-pushed
the
host_transport_node_collection
branch
from
49512a2 to
9c05e13
Compare
Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
host_transport_node_collection
branch
from
9c05e13 to
7b1ff98
Compare
|
/test-all |
No description provided.