Use general names for attributes of hostSwitch #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
hostSwitch_IDvsPath
branch
from
d04d90a to
a193131
Compare
annakhm
approved these changes
Sep 20, 2023
|
@ksamoray, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
ksamoray
force-pushed
the
hostSwitch_IDvsPath
branch
from
b4b1d20 to
4d6666d
Compare
HostSwitch schema is used in both policy and MP with the same struct heirarchy, but id fields within the schema are used to store policy paths for policy resources. Therefore it's worthwhile to keep these with general names without _id suffix. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
hostSwitch_IDvsPath
branch
from
4d6666d to
f370a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostSwitch schema is used in both policy and MP with the same struct heirarchy, but id fields within the schema are used to store policy paths for policy resources. Therefore it's worthwhile to keep these with general names without _id suffix.