Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default EdgeCluster name #986

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

GraysonWu
Copy link
Collaborator

No description provided.

@ksamoray
Copy link
Collaborator

In the new topologies which I deploy with Terraform, the names are actually lowercased :)
If we want to use uppercase naming, I'll change that as well.

@salv-orlando
Copy link
Member

These are not NSX defaults, but rather default settings for the process used to deploy NSX. As @ksamoray mentioned, we will shortly start using topologies deployed via Terraform and defaulting to lower case names.

Also, any NSX user should be able to run these tests on their own topology and have a different name for the edge cluster to use in tests.
If the above makes sense, perhaps these constants should become variables that are read from a config file.

As this might take time for the time being can use two values depending on backend NSX version?

@ksamoray
Copy link
Collaborator

ksamoray commented Oct 3, 2023

@salv-orlando these values are just default names which are used in the testing environments, the CI sets these with environment vars and I already changed the topology to use uppercase values as the GM testing deployments use.

@salv-orlando
Copy link
Member

Discussed with @ksamoray and @annakhm - it's fine to change default value for edge cluster names, but there is no reason for updating documentation.

@GraysonWu GraysonWu force-pushed the mod-default-ec-name branch from 98a2147 to 5c20fae Compare October 9, 2023 01:34
@GraysonWu
Copy link
Collaborator Author

/test-all

@GraysonWu GraysonWu force-pushed the mod-default-ec-name branch from 5c20fae to 0ddd168 Compare October 10, 2023 02:05
@ksamoray
Copy link
Collaborator

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator

/test-all

@GraysonWu GraysonWu merged commit 23f2b83 into vmware:master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants