-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing vds info with r/cluster
import
#235
Draft
burnsjared0415
wants to merge
1
commit into
vmware:main
Choose a base branch
from
burnsjared0415:bug/fix-vds-portgroups_nioc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: missing vds info with r/cluster
import
#235
burnsjared0415
wants to merge
1
commit into
vmware:main
from
burnsjared0415:bug/fix-vds-portgroups_nioc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnsjared0415
changed the title
fix: missing vds info with r/cluster import
🚧fix: missing vds info with r/cluster import
Aug 22, 2024
tenthirtyam
changed the title
🚧fix: missing vds info with r/cluster import
🚧 fix: missing vds info with Aug 22, 2024
r/cluster
import
tenthirtyam
reviewed
Aug 23, 2024
tenthirtyam
reviewed
Aug 23, 2024
tenthirtyam
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI caught that the err
is assigned but not used.
getFlattenedVdsSpecsForRefs
returns both a slice of maps and an error. So the err
is necessary to handle potential errors from the apiClient.Clusters.GetVdses
.
tenthirtyam
reviewed
Aug 23, 2024
tenthirtyam
reviewed
Aug 23, 2024
4 tasks
here is what the results are now:
|
Updating Cluster import to solve issues where vds is blank on data source. Signed-off-by: Jared Burns <[email protected]>
burnsjared0415
force-pushed
the
bug/fix-vds-portgroups_nioc
branch
from
August 27, 2024 14:26
f364358
to
e3d8f78
Compare
tenthirtyam
changed the title
🚧 fix: missing vds info with
fix: missing vds info with Sep 3, 2024
r/cluster
importr/cluster
import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Updating Cluster import to solve issues where vds is blank on data source.
Type of Pull Request
Please describe:
Related to Existing Issues
Ref: #210
Test and Documentation Coverage
For bug fixes or features:
Breaking Changes?