Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add d/host #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add d/host #236

wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Aug 23, 2024

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Adds a data source for host: data/vcf_host.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #200

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.
Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccDataSourceVcfHost$ github.com/vmware/terraform-provider-vcf/internal/provider

ok  	github.com/vmware/terraform-provider-vcf/internal/provider	(cached)

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added enhancement Enhancement datasource Provider Datasource labels Aug 23, 2024
@tenthirtyam tenthirtyam added this to the v0.11.0 milestone Aug 23, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 23, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review provider Provider labels Aug 23, 2024
@tenthirtyam tenthirtyam marked this pull request as draft August 23, 2024 18:30
@tenthirtyam tenthirtyam changed the title feat: add d/host 🚧 feat: add d/host Aug 23, 2024
@tenthirtyam tenthirtyam modified the milestones: v0.11.0, On Deck Aug 23, 2024
@tenthirtyam tenthirtyam linked an issue Aug 23, 2024 that may be closed by this pull request
4 tasks
@tenthirtyam tenthirtyam mentioned this pull request Aug 23, 2024
4 tasks
examples/data-sources/host/vcf_host.tf Show resolved Hide resolved
internal/provider/data_host.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam marked this pull request as ready for review August 26, 2024 21:08
@tenthirtyam tenthirtyam marked this pull request as draft August 27, 2024 02:30
@tenthirtyam tenthirtyam force-pushed the feat/host-datasource branch 4 times, most recently from 3aab2c8 to 000d1c7 Compare August 27, 2024 03:58
@tenthirtyam tenthirtyam force-pushed the feat/host-datasource branch 2 times, most recently from 450f477 to e043dc2 Compare August 27, 2024 18:13
@tenthirtyam tenthirtyam changed the title 🚧 feat: add d/host feat: add d/host Aug 27, 2024
@tenthirtyam tenthirtyam modified the milestones: On Deck, v0.11.0 Aug 27, 2024
@tenthirtyam tenthirtyam force-pushed the feat/host-datasource branch 2 times, most recently from 7d55929 to 8c3a80e Compare August 27, 2024 19:48
Adds a data source for host: `data/vcf_host`.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam
Copy link
Contributor Author

I've re-written it but still haveing some troubles getting the data to come through to the state.

@tenthirtyam tenthirtyam modified the milestones: v0.11.0, On Deck Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource Provider Datasource documentation Documentation enhancement Enhancement needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for d/vcf_host
3 participants