Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: error strings #287

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: error strings #287

merged 1 commit into from
Dec 4, 2024

Conversation

tenthirtyam
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Error strings should not be capitalized or end with punctuation because they might appear among other context.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Error strings should not be capitalized or end with punctuation because they might appear among other context.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added chore Chore technical-debt Technical Debt labels Dec 4, 2024
@tenthirtyam tenthirtyam added this to the v1.15.2 milestone Dec 4, 2024
@tenthirtyam tenthirtyam self-assigned this Dec 4, 2024
@github-actions github-actions bot added the needs-review Needs Review label Dec 4, 2024
@tenthirtyam tenthirtyam merged commit dae929f into main Dec 4, 2024
6 checks passed
@tenthirtyam tenthirtyam deleted the chore/error-strings branch December 4, 2024 17:03
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant