Merge pull request #73 from vnma0/72-fix

Completely handle all unhandled promise in db
vnma0 · Apr 1, 2019 · 0ddd5bc · 0ddd5bc
2 parents 68aabe8 + c80c42b
commit 0ddd5bc
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/src/data/database.js b/src/data/database.js
@@ -356,9 +356,14 @@ function readSubmission(sub_id) {
                     reject(new Error(`Invalid Submission's ID: ${sub_id}`));
                 else
                     readUserByID(docs.user_id)
-                        .then((res) => {
-                            docs.username = res.username;
-                        })
+                        .then(
+                            (res) => {
+                                docs.username = res.username;
+                            },
+                            () => {
+                                docs.username = null;
+                            }
+                        )
                         .finally(() => {
                             resolve(docs);
                         });
@@ -432,9 +437,14 @@ function readSubmissionSrc(sub_id) {
                     reject(new Error(`Invalid Submission's ID: ${sub_id}`));
                 else
                     readUserByID(docs.user_id)
-                        .then((res) => {
-                            docs.username = res.username;
-                        })
+                        .then(
+                            (res) => {
+                                docs.username = res.username;
+                            },
+                            () => {
+                                docs.username = null;
+                            }
+                        )
                         .finally(() => {
                             resolve(docs);
                         });