-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gallery JupyterHub service #17
Conversation
This unauthenticated hub service can render our gallery page easily, and launch a new user + server per gallery launch. This solves a number of problems: 1. Letting users view multiple galleries at once, without having to do complex things with named servers 2. Back button works correctly, since it no longer sends you to the spawn page (Fixes #3) 3. Much easier to iterate and work on, since this is just a tornado application 4. We have full access to the hub API, which can be very useful Putting this in /hub/spawn was a hack, and IMO making this into a service is the 'right' thing to do
/cc @jtpio (and Theo, whose GitHub handle I know not) who were working on something very similar to this at the hackathon, but for a very different use case. |
- Send users to exact dashboard, not notebook server - Mark the urls in gallery.yaml as relative, not absolute. urlencode otherwise will ignore the first URL passed to it.
This should get them installed at the right time. Should probably remove tljh_extra_hub_packages in favor of this. I'm also hoping the last released version of binderhub is good enough (I think it is)
@pbugnion try this out at http://35.238.76.193/services/gallery/ |
Ok, now available at http://35.238.76.193 directly! This is ready for review :) |
This will create problems with idle culling, see jupyterhub/binderhub#831. We already don't do idle culling though... |
Really nice @yuvipanda! cc @tam203 (Theo) |
We just got access to OVH resources so we can start looking into getting this to run on K8s as well. |
@jtpio awesome. Although I am wondering how image start performance is gonna be. It'll need an image registry and pushing to everywhere... |
@jtpio Do you think I can get access to the OVH account? :) |
/cc @danielballan who is also interested in the work @jtpio and @tam203 are doing |
Of course! Will come back to you with the details. |
Co-Authored-By: Jeremy Tuloup <[email protected]>
Currently testing on http://51.77.228.103, seems to be working fine including the back button.
|
Seems like it's fixed after updating to the latest version of voila. See #19 |
Perfect, thanks @yuvipanda! |
This unauthenticated hub service can render our
gallery page easily, and launch a new user + server
per gallery launch. This solves a number of problems:
having to do complex things with named servers
to the spawn page (Fixes There is no easy way to go back to the home page #3)
tornado application
Putting this in /hub/spawn was a hack, and IMO making this
into a service is the 'right' thing to do
Todo: