Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gallery JupyterHub service #17

Merged
merged 8 commits into from
Jun 13, 2019
Merged

Add a gallery JupyterHub service #17

merged 8 commits into from
Jun 13, 2019

Conversation

yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jun 12, 2019

This unauthenticated hub service can render our
gallery page easily, and launch a new user + server
per gallery launch. This solves a number of problems:

  1. Letting users view multiple galleries at once, without
    having to do complex things with named servers
  2. Back button works correctly, since it no longer sends you
    to the spawn page (Fixes There is no easy way to go back to the home page #3)
  3. Much easier to iterate and work on, since this is just a
    tornado application
  4. We have full access to the hub API, which can be very useful

Putting this in /hub/spawn was a hack, and IMO making this
into a service is the 'right' thing to do

Todo:

  • Integrate this into the TLJH plugin
  • Figure out what to do about binderhub dependency
  • Make this the 'home page' when people visit the domain

This unauthenticated hub service can render our
gallery page easily, and launch a new user + server
per gallery launch. This solves a number of problems:

1. Letting users view multiple galleries at once, without
   having to do complex things with named servers
2. Back button works correctly, since it no longer sends you
   to the spawn page (Fixes #3)
3. Much easier to iterate and work on, since this is just a
   tornado application
4. We have full access to the hub API, which can be very useful

Putting this in /hub/spawn was a hack, and IMO making this
into a service is the 'right' thing to do
@yuvipanda
Copy link
Contributor Author

/cc @jtpio (and Theo, whose GitHub handle I know not) who were working on something very similar to this at the hackathon, but for a very different use case.

- Send users to exact dashboard, not notebook server
- Mark the urls in gallery.yaml as relative, not absolute.
  urlencode otherwise will ignore the first URL passed to
  it.
This should get them installed at the right time.
Should probably remove tljh_extra_hub_packages in
favor of this.

I'm also hoping the last released version of binderhub
is good enough (I think it is)
@yuvipanda
Copy link
Contributor Author

@pbugnion try this out at http://35.238.76.193/services/gallery/

@yuvipanda yuvipanda changed the title [WIP] Add a gallery JupyterHub service Add a gallery JupyterHub service Jun 12, 2019
@yuvipanda
Copy link
Contributor Author

Ok, now available at http://35.238.76.193 directly! This is ready for review :)

@yuvipanda yuvipanda requested a review from pbugnion June 12, 2019 14:50
@yuvipanda
Copy link
Contributor Author

This will create problems with idle culling, see jupyterhub/binderhub#831. We already don't do idle culling though...

@jtpio
Copy link
Member

jtpio commented Jun 12, 2019

Really nice @yuvipanda!

cc @tam203 (Theo)

@jtpio
Copy link
Member

jtpio commented Jun 12, 2019

We just got access to OVH resources so we can start looking into getting this to run on K8s as well.

@yuvipanda
Copy link
Contributor Author

@jtpio awesome. Although I am wondering how image start performance is gonna be. It'll need an image registry and pushing to everywhere...

@yuvipanda
Copy link
Contributor Author

@jtpio Do you think I can get access to the OVH account? :)

@yuvipanda
Copy link
Contributor Author

/cc @danielballan who is also interested in the work @jtpio and @tam203 are doing

@jtpio
Copy link
Member

jtpio commented Jun 13, 2019

@jtpio Do you think I can get access to the OVH account? :)

Of course! Will come back to you with the details.

@yuvipanda yuvipanda mentioned this pull request Jun 13, 2019
5 tasks
@jtpio
Copy link
Member

jtpio commented Jun 13, 2019

Currently testing on http://51.77.228.103, seems to be working fine including the back button.

country-indicators and render-stl work fine, but the gaussian-density example is giving 500s.

@jtpio
Copy link
Member

jtpio commented Jun 13, 2019

but the gaussian-density example is giving 500s.

Seems like it's fixed after updating to the latest version of voila. See #19

@yuvipanda
Copy link
Contributor Author

@jtpio I rebuilt the images with #19 and it seems to work.

@jtpio
Copy link
Member

jtpio commented Jun 13, 2019

Perfect, thanks @yuvipanda!

@jtpio jtpio merged commit ed7c9a6 into master Jun 13, 2019
@jtpio jtpio deleted the service branch June 13, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no easy way to go back to the home page
2 participants