Fix report name + output widget

voila-dashboards · Oct 16, 2024 · 091b3b7 · 091b3b7
1 parent b267e79
commit 091b3b7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
@@ -76,38 +76,38 @@ jobs:
       - name: Set test report name for progressive rendering
         if: always() && matrix.progressive_rendering == true
         run: |
-          echo "TEST_REPORT_NAME=progressive-voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
-          echo "TEST_ASSETS_NAME=progressive-voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
-          echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
+          echo "TEST_REPORT_NAME=progressive-voila-test-report-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
+          echo "TEST_ASSETS_NAME=progressive-voila-test-assets-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
+          echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
 
       - name: Set test report name for non-progressive rendering
         if: always() && matrix.progressive_rendering == false
         run: |
-          echo "TEST_REPORT_NAME=voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
-          echo "TEST_ASSETS_NAME=voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
-          echo "TEST_BENCHMARK_NAME=voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV
+          echo "TEST_REPORT_NAME=voila-test-report-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
+          echo "TEST_ASSETS_NAME=voila-test-assets-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
+          echo "TEST_BENCHMARK_NAME=voila-test-benchmark-${{ matrix.jupyter-server-version }}-${{ matrix.ipywidgets }}" >> $GITHUB_ENV
 
       - name: Upload Playwright Test assets
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.TEST_ASSETS_NAME }}${{ matrix.ipywidgets }}
+          name: ${{ env.TEST_ASSETS_NAME }}
           path: |
             ui-tests/test-results
 
       - name: Upload Playwright Benchmark report
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.TEST_BENCHMARK_NAME }}${{ matrix.ipywidgets }}
+          name: ${{ env.TEST_BENCHMARK_NAME }}
           path: |
             ui-tests/benchmark-results
 
       - name: Upload Playwright Test report
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.TEST_REPORT_NAME }}${{ matrix.ipywidgets }}
+          name: ${{ env.TEST_REPORT_NAME }}
           path: |
             ui-tests/playwright-report
 

diff --git a/packages/widgets_manager7/src/index.ts b/packages/widgets_manager7/src/index.ts
@@ -20,7 +20,7 @@ import {
   StyleView
 } from '@jupyter-widgets/base';
 import { JUPYTER_CONTROLS_VERSION } from '@jupyter-widgets/controls/lib/version';
-import { WidgetRenderer } from '@jupyter-widgets/jupyterlab-manager';
+import { WidgetRenderer, output } from '@jupyter-widgets/jupyterlab-manager';
 import {
   JupyterFrontEnd,
   JupyterFrontEndPlugin
@@ -168,6 +168,12 @@ const widgetManager: JupyterFrontEndPlugin<IJupyterWidgetRegistry> = {
       }
     });
 
+    manager.register({
+      name: '@jupyter-widgets/output',
+      version: output.OUTPUT_WIDGET_VERSION,
+      exports: output as any
+    });
+
     app.started.then(async () => {
       await manager._loadFromKernel();
     });