Merge pull request #501 from mariobuikhuizen/fix_template_title

fix: the default title in the template is always Notebook
voila-dashboards · Jan 29, 2020 · 8557d9d · 8557d9d
2 parents 3b06c0b + 3cefe67
commit 8557d9d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/tests/app/execute_test.py b/tests/app/execute_test.py
@@ -19,7 +19,7 @@ def test_hello_world(http_client, base_url):
     assert response.code == 200
     html_text = response.body.decode('utf-8')
     assert 'Hi Voila' in html_text
-    assert 'print' not in html_text, 'by default the source code should be stripped'
+    assert 'print(' not in html_text, 'by default the source code should be stripped'
     assert 'test_template.css' not in html_text, "test_template should not be the default"
 
 

diff --git a/tests/server/execute_test.py b/tests/server/execute_test.py
@@ -8,5 +8,5 @@ def test_hello_world(http_client, print_notebook_url):
     assert response.code == 200
     html_text = response.body.decode('utf-8')
     assert 'Hi Voila' in html_text
-    assert 'print' not in html_text, 'by default the source code should be stripped'
+    assert 'print(' not in html_text, 'by default the source code should be stripped'
     assert 'test_template.css' not in html_text, "test_template should not be the default"
diff --git a/voila/handler.py b/voila/handler.py
@@ -59,11 +59,17 @@ async def get(self, path=None):
             return
         self.cwd = os.path.dirname(notebook_path)
 
+        path, basename = os.path.split(notebook_path)
+        notebook_name = os.path.splitext(basename)[0]
+
         # render notebook to html
         resources = {
             'base_url': self.base_url,
             'nbextensions': nbextensions,
-            'theme': self.voila_configuration.theme
+            'theme': self.voila_configuration.theme,
+            'metadata': {
+                'name': notebook_name
+            }
         }
 
         # include potential extra resources