Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mathjax setting #1362

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Jul 31, 2023

References

Finally, I still use the CDN for the Mathjax files since the jupyter_server_mathjax does not provide the required files for the current config.

Closes #516

mathjax

Code changes

User-facing changes

New setting for Voila app:

  • mathjax_config: Configuration for Mathjax , default to TeX-AMS_CHTML-full,Safe
  • mathjax_url: URL to load Mathjax, default to https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.7/MathJax.js

Backwards-incompatible changes

@trungleduc trungleduc added the enhancement New feature or request label Jul 31, 2023
@trungleduc trungleduc added this to the 0.5.0 milestone Jul 31, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/mathjax

@@ -23,6 +23,7 @@
"@jupyterlab/markdownviewer-extension": "^4.0.0",
"@jupyterlab/markedparser-extension": "^4.0.0",
"@jupyterlab/mathjax-extension": "^4.0.0",
"@jupyterlab/mathjax2-extension": "^4.0.0-alpha.21",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the 4.0.0 is not released on npm

@trungleduc trungleduc marked this pull request as ready for review August 1, 2023 08:34
@trungleduc trungleduc added the bug Something isn't working label Aug 1, 2023
@martinRenou martinRenou merged commit cd33c55 into voila-dashboards:main Aug 1, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voila cannot show Greek letter (latex format) correctly
2 participants