Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial k8s deployment #40

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

westonpace
Copy link
Contributor

In order to prepare substrait-fiddle to be hosted in a more automated way I created a k8s deployment. I was able to use this to deploy to GKE and http://substrait-fiddle.com is live once again.

A few caveats:

  • HTTPS is not enabled yet. I'll work on that
  • This deployment uses GKE's ingress controller which is pretty limited. Notably, it cannot rewrite paths. As a result I needed to change the fast-api endpoints to start with /api (instead of using rewrites).

@EpsilonPrime
Copy link
Contributor

@sanjibansg Is the merge conflict something you can easily deal with or should I investigate?

@sanjibansg
Copy link
Contributor

@sanjibansg Is the merge conflict something you can easily deal with or should I investigate?

I have fixed the merge conflicts, can you two please review it? Thanks!

@EpsilonPrime @richtia

@sanjibansg sanjibansg merged commit e29b16c into voltrondata:main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants