Add more bunch of test and remove old FIXME

voodoos · Apr 10, 2024 · 86e76b3 · 86e76b3
1 parent 615014e
commit 86e76b3
Showing 1 changed file with 78 additions and 3 deletions.
diff --git a/tests/test-dirs/destruct/destruct-fun.t b/tests/test-dirs/destruct/destruct-fun.t
@@ -4,7 +4,6 @@ Test case-analysis on a function parameter:
   > let f x (bb : bool) y = something
   > EOF
 
-FIXME UPGRADE 5.2: this was working before the upgrade
   $ $MERLIN single case-analysis -start 1:10 -end 1:11 \
   > -filename fun.ml <fun.ml | \
   > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr -d '\n' | jq '.'
@@ -55,7 +54,6 @@ FIXME UPGRADE 5.2: this was working before the upgrade
   > let f x ((false as bb) : bool) y = something
   > EOF
 
-FIXME UPGRADE 5.2: this was not working before the upgrade
   $ $MERLIN single case-analysis -start 1:11 -end 1:15 \
   > -filename fun.ml <fun.ml | \
   > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr -d '\n' | jq '.'
@@ -81,7 +79,6 @@ FIXME UPGRADE 5.2: this was not working before the upgrade
   > let f x (_ as bb : bool) y = something
   > EOF
 
-FIXME UPGRADE 5.2: this was working before the upgrade
   $ $MERLIN single case-analysis -start 1:10 -end 1:10 \
   > -filename fun.ml <fun.ml | \
   > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr -d '\n' | jq '.'
@@ -154,3 +151,81 @@ FIXME UPGRADE 5.2: this was working before the upgrade
     ],
     "notifications": []
   }
+
+  $ cat >fun.ml <<EOF
+  > type t = Foo of int option * string
+  > let f a (b: t) c = something
+  > EOF
+
+  $ $MERLIN single case-analysis -start 2:10 -end 2:10 \
+  > -filename fun.ml <fun.ml | \
+  > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr '\n' ' ' | jq '.'
+  {
+    "class": "return",
+    "value": [
+      {
+        "start": {
+          "line": 2,
+          "col": 9
+        },
+        "end": {
+          "line": 2,
+          "col": 10
+        }
+      },
+      "Foo (_,_)"
+    ],
+    "notifications": []
+  }
+
+  $ cat >fun.ml <<EOF
+  > type t = Foo of { foo: int; bar: string }
+  > let f a (b: t) c = something
+  > EOF
+
+  $ $MERLIN single case-analysis -start 2:10 -end 2:10 \
+  > -filename fun.ml <fun.ml | \
+  > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr '\n' ' ' | jq '.'
+  {
+    "class": "return",
+    "value": [
+      {
+        "start": {
+          "line": 2,
+          "col": 9
+        },
+        "end": {
+          "line": 2,
+          "col": 10
+        }
+      },
+      "Foo _"
+    ],
+    "notifications": []
+  }
+
+  $ cat >fun.ml <<EOF
+  > type _ t = Foo : int t | Bar : float t
+  > let f a (b: int t) c = something
+  > EOF
+
+  $ $MERLIN single case-analysis -start 2:10 -end 2:10 \
+  > -filename fun.ml <fun.ml | \
+  > sed -e 's/, /,/g' | sed -e 's/ *| */|/g' | tr -d '\n' | jq '.'
+  {
+    "class": "return",
+    "value": [
+      {
+        "start": {
+          "line": 2,
+          "col": 9
+        },
+        "end": {
+          "line": 2,
+          "col": 10
+        }
+      },
+      "Foo"
+    ],
+    "notifications": []
+  }