feat!: Reimplement simple subscriber as oop #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiyionPrime
force-pushed
the
feat/simple-subscriber-oop
branch
from
7161e6d to
a108151
Compare
AiyionPrime
changed the title
AiyionPrime
requested review from
philipp-caspers,
DS424 and
tobiasbrinker
as code owners
|
The commits should reflect whether they are about the OPC UA side or the ROS side of the bridge. |
|
I do not understand the first commit message. Feels like something is missing. |
philipp-caspers
approved these changes
Jul 30, 2024
an object oriented variant of the simplistic subscriber already in place, which features a vastly reduced interface for easier use. Use this in launch_subscriber to avoid duplication.
for SimpleSubscriber
in favor of the oop variant and use the latter in main.
which was MonitoredItem before. This should help to ease Implementation of callbacks without deeper knowledge of the OPC UA crate.
in favor of an OPC UA subscription callback invocation with 'static lifetime.
AiyionPrime
force-pushed
the
feat/simple-subscriber-oop
branch
from
a108151 to
a754672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.