add readLegal functionality #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovByte
requested changes
Sep 15, 2024
|
|
||
| // TODO: This will parse the markdown in the terms directory and get the text from the file (except from the title) and display it in the embed | ||
| const data: CreateSlashApplicationCommand = { | ||
| name: "legal", |
There was a problem hiding this comment.
The command name was supposed to be readLegal
| description: "The legal document to read", | ||
| required: true, | ||
| choices: [ | ||
| { name: "Terms of Service", value: "tos" }, |
There was a problem hiding this comment.
You forgot the choices "privacy policy" and "terms of service" (long version)
| if (contentWithoutTitle.length > 4096) { | ||
| const chunks = contentWithoutTitle.match(/.{1,2000}/g) || []; | ||
| for (let i = 1; i < chunks.length; i++) { | ||
| await responder.respond(chunks[i]); |
There was a problem hiding this comment.
I would prefer you embed this with the title "Content Policy" or "Terms of Service" and abstract code splitting with a module for doing it. It would take in an embed object, and if the field, such as the description, is over the limit, it would add ...(rest of the field). It could also take in a string and have a normal respond message split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.