Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTX parser rewrite #267

Merged
merged 47 commits into from
Sep 4, 2024
Merged

PTX parser rewrite #267

merged 47 commits into from
Sep 4, 2024

Conversation

vosen
Copy link
Owner

@vosen vosen commented Aug 14, 2024

Our PTX parser has been working surprisingly well and has been the same basically from the inception.
Lately, I've been running into limitations of the parser when working on other areas of the codebase. This rewrite is done for those explicit reasons (not all of them will apply right now):

  • Better support of inline assembly (out-of-order instruction modifiers)
  • More precise tracking of flush-to-zero flag
  • Better support for instruction visitors (we can only do move-and-map right now, but we want visit-by-ref and visit-by-mut-ref)
  • Less error-prone instruction definitions (no more ArgumentDescriptor)

Side benefits:

  • Slightly better compilation times
  • PTX parser will be split to a separate crate, making it easier for people who want to use just that part of ZLUDA

@erkinalp
Copy link

v4-reborn 🚀

@vosen vosen marked this pull request as ready for review September 3, 2024 17:12
@vosen vosen merged commit 193eb29 into master Sep 4, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants