Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #37

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Improve error messages #37

wants to merge 20 commits into from

Commits on Jul 7, 2023

  1. update .gitignore

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2a850d2 View commit details
    Browse the repository at this point in the history

  2. create a test that highlight a problem 

    the error is confusing and unhelpful
    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7f7bcd5 View commit details
    Browse the repository at this point in the history

  3. add try/catch to better understand the problem

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2ab7df3 View commit details
    Browse the repository at this point in the history

  4. update the test so fix is clear

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8bdaa30 View commit details
    Browse the repository at this point in the history

  5. succ fix, 1

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f1cc54a View commit details
    Browse the repository at this point in the history

  6. update typescript

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1baeecb View commit details
    Browse the repository at this point in the history

  7. update jest and ts-jest

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    03af007 View commit details
    Browse the repository at this point in the history

  8. use causes to propagate the error

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    25eeedd View commit details
    Browse the repository at this point in the history

  9. improve the error message

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    749224e View commit details
    Browse the repository at this point in the history

  10. find the place where error is ignored

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4b1fbe5 View commit details
    Browse the repository at this point in the history

  11. try to see class error

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3bbfe8c View commit details
    Browse the repository at this point in the history

  12. add helper fn

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    068c081 View commit details
    Browse the repository at this point in the history

  13. try not to eat the error

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bddfb0d View commit details
    Browse the repository at this point in the history

  14. improve the error message

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a514f9e View commit details
    Browse the repository at this point in the history

  15. kill class tests

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    937af0b View commit details
    Browse the repository at this point in the history

  16. improve our tests

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2f5bba8 View commit details
    Browse the repository at this point in the history

  17. remove ts-ignore

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7dc89bd View commit details
    Browse the repository at this point in the history

  18. refactor

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8deffd7 View commit details
    Browse the repository at this point in the history

  19. refactor

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    966ea07 View commit details
    Browse the repository at this point in the history

  20. revert

    @yanisurbis
    yanisurbis committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    53e45fb View commit details
    Browse the repository at this point in the history