Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Group #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dynamic Group #62

wants to merge 1 commit into from

Conversation

danielgural
Copy link
Contributor

What changes are proposed in this pull request?

Added Dynamic Group examples

Copy link
Contributor

@jacobmarks jacobmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include some exposition in the notebook? It's okay if the contents are very similar to the contents of the T&T blog post, but if you're going to make an examples notebook, it should also be able to stand on its own

<img src="https://user-images.githubusercontent.com/25985824/104792428-60f9cc00-576c-11eb-95a4-5709d803023a.png" height="22" width="22">
</a>
</td>
<td><a href="examples/Grouped Datasets.ipynb">Dynamic Group Tips & Tricks</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're linking to the wrong notebook

<img src="https://user-images.githubusercontent.com/25985824/104792428-60f9cc00-576c-11eb-95a4-5709d803023a.png" height="22" width="22">
</a>
</td>
<td><a href="examples/Grouped Datasets.ipynb">Dynamic Group Tips & Tricks</a></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that it's in the README, but it still isn't in the index.yaml. Can you add those changes to the PR as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants