fix state not populating in operator

[CamronStaley]

What changes are proposed in this pull request?

fix state not populating in operator

How is this patch tested? If it is not, please explain why.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

Summary by CodeRabbit

• New Features

  • Enhanced operator execution with performance tracking capabilities.
  • Improved context management for operator execution.

• Bug Fixes

  • Enhanced error handling for loading operators from the server, providing clearer logging of issues.

[coderabbitai]

Walkthrough

The changes in this pull request primarily enhance operator execution and context management within the app/packages/operators/src/operators.ts file. A new parameter, query_performance, has been added to several functions, enabling performance tracking during operator execution. Additionally, error handling improvements have been made in the loadOperatorsFromServer function to better capture and log errors when loading operators from the server.

Changes

File	Change Summary
app/packages/operators/src/operators.ts	- Added query_performance parameter to executeOperatorAsGenerator, resolveRemoteType, resolveExecutionOptions, fetchRemotePlacements, and resolveLocalPlacements. - Enhanced error handling in loadOperatorsFromServer for better logging of server loading issues.

Possibly related PRs

• Query performance operators #4875: This PR modifies the app/packages/operators/src/operators.ts file to add a queryPerformance property to the RawContext type and the ExecutionContext class, which is directly related to the changes made in the main PR regarding the query_performance parameter in various functions.

Suggested labels

app

Suggested reviewers

• minhtuev
• benjaminpkane

Poem

In the code where operators play,
A new parameter joins the fray.
With performance tracking now in sight,
Errors caught, logging feels just right.
Hops of joy, as functions align,
A robust system, oh how it shines! 🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d0f2abd and f015528.

📒 Files selected for processing (1)

• app/packages/operators/src/operators.ts (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/packages/operators/src/operators.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

🔇 Additional comments (1)

app/packages/operators/src/operators.ts (1)

562-562: Verify server-side handling of query_performance parameter

The query_performance parameter has been added to multiple server requests. Ensure that the corresponding server-side endpoints accept and properly handle this new parameter to prevent any issues.

Run the following script to confirm that the server code handles query_performance:

Also applies to: 834-834, 911-911, 945-945

✅ Verification successful

Let me gather more specific information about the server-side handling.

---

Based on the findings, I can now provide a final response:

query_performance is properly handled through server-side configuration

The parameter is integrated into FiftyOne's configuration system with proper server-side support:

• It's defined in the server configuration as enable_query_performance and default_query_performance boolean flags
• The feature can be controlled through environment variables and config files
• The server validates these settings through the AppConfig class

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for server-side handling of 'query_performance' in API endpoints.

# Test: Find occurrences where 'query_performance' is processed server-side.
rg -F 'query_performance'

Length of output: 3267

---

Script:

#!/bin/bash
# Search for query_performance parameter handling in server code
ast-grep --pattern 'def $_(self, $$$, query_performance, $$$):'

# Look for the actual processing of query_performance in the query execution
rg -A 5 'query_performance.*=' fiftyone/server/query.py

Length of output: 123

---

Script:

#!/bin/bash
# Look for query_performance configuration and handling in server code
rg -A 10 'class.*Config' fiftyone/core/config.py

# Check how query_performance is used in the server query execution
rg -A 10 'class.*Query' fiftyone/server/query.py

# Look for any validation or processing of query_performance
rg -B 2 -A 5 'query_performance' fiftyone/server/query.py

Length of output: 7398

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[minhtuev]

LGTM 👍