Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README.md to highlight build_versions.json and add .gitlab-ci.yaml example #5

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented Apr 10, 2024

this is a draft, i want to see how trivy reacts to the new gem

@bastelfreak bastelfreak changed the title Add rspec_junit_formatter and gitlab-ci.yaml exmplae Add rspec_junit_formatter and gitlab-ci.yaml example Apr 10, 2024
@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Apr 10, 2024

if this is added, i want to create a rake-task "spec:junit:report". but i am not sure how to do this in a propper way.

I need to do this but also call spec_prep somehow.

RSpec::Core::RakeTask.new('spec:junit:report') do |t|
  t.rspec_opts = "--format documentation --format RspecJunitFormatter --out rspec.xml"
end

@bastelfreak
Copy link
Member

RSpec::Core::RakeTask.new('spec:junit:report') do |t|
  Rake::Task[:spec_prep].invoke
  t.rspec_opts = "--format documentation --format RspecJunitFormatter --out rspec.xml"
end

@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Apr 10, 2024

this easy, okay thx

@bastelfreak
Copy link
Member

Everything I know about rake comes from https://github.com/puppetlabs/puppetlabs_spec_helper/blob/main/lib/puppetlabs_spec_helper/rake_tasks.rb :D It has some nice examples that I keep copying.

@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Apr 10, 2024

hmpf, does work, but not as expected. it now tries to exec rspec on every file beneath fixtures. i tried to apply exclude patterns, but does not work. somehow i fucked up the whole process ... and now i do a break... 🍰

@rwaffen rwaffen changed the title Add rspec_junit_formatter and gitlab-ci.yaml example update README.md to highlight build_versions.json and add .gitlab-ci.yaml example Apr 11, 2024
@rwaffen rwaffen marked this pull request as ready for review April 11, 2024 08:01
@rwaffen rwaffen requested a review from a team as a code owner April 11, 2024 08:01
@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Apr 11, 2024

i split this up. readme and examples first, rspec_junit_formatter later

@rwaffen rwaffen merged commit a1826f0 into main Apr 11, 2024
6 checks passed
@rwaffen rwaffen deleted the updates branch April 11, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants