Regenerate Redhat 7 facts #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo before merge: Re-add legacy facts as puppet 7 isnt EOL yet |
|
@yakatz sorry to bother you again... do you happen to know how to include the legacy facts when regenerating with 'undle exec rake rhel_alts'? |
|
The script just takes the centos values and does a find/replace for the target os. Since we actually generate rhel facts, it makes more sense to count the rhel facts as authoritative and replace the other way. I submitted a separate PR for that: #303 |
|
The script also only looks at x86_64, not 386 facts |
|
@zilchms Can you rebase this? |
|
Sure, but I am not sure I finished what I set out to do. |
Merged
|
discontinued because: #354 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#304 addressed the discrepancy in the IP addresses of redhat 8 (which is important for the unit test failures in puppet-openvpn).
However, we missed the RedHat 7 facts which a) have the wrong IPv4 addresses for some reason (introduced in #257, which probably broke more than just openvpn) and b) we are missing all RedHat 7 facts except for version 4.2