Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit reading private key from environment variable #294

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Permit reading private key from environment variable #294

merged 2 commits into from
Jan 30, 2020

Conversation

nferch
Copy link
Contributor

@nferch nferch commented Nov 22, 2019

per #284

@bastelfreak
Copy link
Member

Hi @nferch, thanks for the PR. Can you add some documentation to the README.md?

@nferch
Copy link
Contributor Author

nferch commented Nov 25, 2019

Hi @nferch, thanks for the PR. Can you add some documentation to the README.md?

Done.

@nferch
Copy link
Contributor Author

nferch commented Jan 14, 2020

@alexjfisher @binford2k @crayfishx @mmerfort any opportunity for a review? thanks.

@ghoneycutt ghoneycutt self-requested a review January 14, 2020 20:23
@bastelfreak
Copy link
Member

thanks for the PR!

@bastelfreak bastelfreak merged commit 0ca9665 into voxpupuli:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoneycutt ghoneycutt ghoneycutt approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher

@binford2k binford2k Awaiting requested review from binford2k

@crayfishx crayfishx Awaiting requested review from crayfishx

@mmerfort mmerfort Awaiting requested review from mmerfort

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nferch @bastelfreak @ghoneycutt