Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 179 Fix parsing of empty eyaml values #323

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Issue 179 Fix parsing of empty eyaml values #323

wants to merge 2 commits into from

Conversation

pillarsdotnet
Copy link

This PR contains fixes for #179 and should cause the failing tests from #321 to pass.

@pillarsdotnet pillarsdotnet changed the title Issue 179 fix Issue 179 Fix parsing of empty eyaml values Jul 29, 2021
This was referenced Jul 29, 2021
Closed
Open
bastelfreak
bastelfreak approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but it would be nice if someone with more hiera-eyaml knowledge reviews it as well

@pillarsdotnet
Copy link
Author

The fix may be correct, but the tests are inadequate, as evidenced by #321

@pillarsdotnet pillarsdotnet marked this pull request as draft August 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@trevor-vaughan trevor-vaughan Awaiting requested review from trevor-vaughan

@alexjfisher alexjfisher Awaiting requested review from alexjfisher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pillarsdotnet @kenyon @bastelfreak