Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.0 #362

Closed
wants to merge 2 commits into from
Closed

Release 3.5.0 #362

wants to merge 2 commits into from

Conversation

robbat2
Copy link
Contributor

@robbat2 robbat2 commented Jan 1, 2024

Please fast-forward merge and include the v3.5.0 tag from my repo; or otherwise generate a new gpg-signed tag.

Signed-off-by: Robin H. Johnson <[email protected]>
@robbat2 robbat2 mentioned this pull request Jan 1, 2024
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should be v4.0.0 since there are breaking changes.

@robbat2
Copy link
Contributor Author

robbat2 commented Jan 1, 2024

@bastelfreak your opinion on calling this v3.5.0 vs v4.0.0?

The changelog autogenerator said it was a "breaking change" based on your PR tags on #351
However under Semantic Versioning rules, I don't think it actually fits:

https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

The API did NOT change, only the dependency did, so it's a minor bump, not a major bump

@robbat2
Copy link
Contributor Author

robbat2 commented Jan 8, 2024

@bastelfreak bump; re what version should this be called; it's not really breaking changes, but I can bump it to 4.0.0 if you want anyway.

@bastelfreak
Copy link
Member

next release hast to be 4.0.0 because there are backwards incompatible changes. I raised a new PR at #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants