Deal with nil branch #221
Open
Deal with nil branch #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can close this since #233 got merged? |
Don't think so. |
default_branch doesn't guarantee a result. This checks for the nil value and raises an exception.
ekohl
force-pushed
the
handle-error-condition
branch
from
7da6a12
to
047b7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_branch doesn't guarantee a result. This checks for the nil value and raises an exception.
This is probably not a good way to deal with it, but it's a lot clearer for the user. I happened to run into this because I didn't have a HEAD for the remote
originsorm .git/refs/remotes/origin/HEADis the reproducer.