Support proxy when downloading remote certificates #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
approved these changes
Jun 5, 2024
manifests/ca.pp
Outdated
| # PEM formatted certificate content | ||
| # This attribute is mutually exclusive with `source` | ||
| # @param allow_insecure_source | ||
| # Wether to allow insecure download or not. |
There was a problem hiding this comment.
Suggested change
| # Wether to allow insecure download or not. | |
| # Whether to allow insecure download or not. |
h-haaks
force-pushed
the
support-proxy-for-ca-download
branch
from
de54c30
to
9f4d491
Compare
h-haaks
force-pushed
the
support-proxy-for-ca-download
branch
from
9f4d491
to
10fe954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adding params to ca_cer::ca so that remote certificates can be downloaded truogh a proxy
This Pull Request (PR) fixes the following issues
Fixes #46