Move and use params only in ca_certs class #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
May 24, 2024
manifests/init.pp
Outdated
| @@ -6,25 +6,63 @@ | |||
| # | |||
| # === Parameters | |||
| # | |||
| # [*package_name*] | |||
There was a problem hiding this comment.
please use puppet-strings style documentation for new parameters
There was a problem hiding this comment.
My plan was to convert everything in a separate PR as that's not backwords-incompatible
There was a problem hiding this comment.
Added a puppet-strings commit
h-haaks
force-pushed
the
params-file-should-only-contain-params
branch
2 times, most recently
from
b750bf1
to
852c4e3
Compare
h-haaks
force-pushed
the
params-file-should-only-contain-params
branch
from
852c4e3
to
9297cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherit and use params class only in the ca_cert class.
Moved ca_file_group and ca_file_mode from ca_cert::ca to ca_cert because I don't see any reason for this to change per certificate file.
This is a preliminary change before moving from params class to hiera.