modulesync 8.0.1 #468
modulesync 8.0.1 #468
Conversation
bastelfreak
force-pushed
the
modulesync
branch
2 times, most recently
from
7b4cf91 to
5fca8f8
Compare
| @@ -26,16 +28,16 @@ | |||
|
|
|||
| describe service('cassandra') do | |||
| it "check Cassandra-#{version} is running and enabled" do | |||
| is_expected.to be_running | |||
| is_expected.to be_enabled | |||
| expect(subject).to be_running | |||
There was a problem hiding this comment.
Why is this better? We use is_expected pretty much everywhere and if Rubocop enforces this new style, I'd be in favor of disabling that cop (unless there's a very good reason).
|
I did a rough cleanup but more work needs to be put into it. I'm not sure if it's worth doing it. I'm not a cassandra expert and the latest release, from 2020-09-18 only has ~3000 downloads on the forge. maybe we just archive the repository. |
| $net_ipv4_tcp_rmem = '4096 87380 16777216' | ||
| $net_ipv4_tcp_wmem = '4096 65536 16777216' | ||
| $java_package = 'openjdk-7-jre-headless' | ||
| } | ||
| '18.04': { |
There was a problem hiding this comment.
This looks like it should be default. openjdk-7-jre-headless didn't exist in Stretch (oldoldstable) so unlikely to exist in anything newer. On the other hand, version 8 is only in Stretch and Buster appears to only have version 11.
|
I'd be in favor of archiving this. |
|
since there has been some disagreement if this should be retired on the IRC, i am going to have a look at the msync pr and try to fix this whole module up |
modulesync 4.0.0