Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/package_hold #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NeatNerdPrime
Copy link

Pull Request (PR) description

Introducing the package_holdparameter

The package_hold parameter allows you to hold the package version in the APT package manager. This is useful when you intend to update the host with 'apt upgrade' (or the bolt task apt action=upgrade from puppetlabs-apt) and keep your gitlab instance at the intended version. This prevents unintended upgrading gitlab and perhaps skipping important upgrade path steps.

@NeatNerdPrime
Copy link
Author

@bastelfreak Thanks for considering my PR.

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 10, 2024
@bastelfreak
Copy link
Member

Thanks for the PR! Can you please add a unit test for the change?

* Introducing the `package_hold`parameter

The `package_hold` parameter allows you to hold the package version in the APT
package manager. This is useful when you intend to update the host with
'apt upgrade' (or the bolt task `apt action=upgrade` from puppetlabs-apt) and
keep your gitlab instance at the intended version. This prevents unintended
upgrading gitlab and perhaps skipping important upgrade path steps.
@NeatNerdPrime
Copy link
Author

And Voila!
Got done in a bit by the style, but it includes the test describes it quite nicely.

Thanks again for considering my PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants