Add download option to jenkins module #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
download-options
branch
2 times, most recently
from
4ac3c88 to
fa06d8c
Compare
evgeni
previously approved these changes
Apr 23, 2024
|
@ekohl @CyberLine bug or enhancement? I'm leaning bug as it fixes unstable downloads? |
|
Welp, EL7's |
evgeni
force-pushed
the
download-options
branch
from
fa06d8c to
39b2ec0
Compare
bastelfreak
reviewed
Apr 24, 2024
This allows forcing HTTP 1.1 per official suggestion[1], since HTTP 2 regularly fails when downloading. cURL on RHEL7 doesn't support HTTP 2 and thus does not have a --http1.1 switch. [1]: jenkins-infra/helpdesk#3078 (comment)
evgeni
force-pushed
the
download-options
branch
from
39b2ec0 to
cb975d4
Compare
evgeni
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows forcing HTTP 1.1 per official suggestion, since HTTP 2 regularly fails when downloading.