Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of deprecation warning #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix of deprecation warning #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manifests/ca.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
ensure => directory,
recurse => true,
links => 'follow',
source_permissions => 'use',
owner => 'root',
mode => '0755',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Is this the correct mode to use? This directory resource has recurse => true, so I think this mode would make all the files under the directory executable. (But maybe that's what's needed? Could you confirm?)

Puppet automatically sets directory browse permissions, so maybe 0644 would be better?
https://puppet.com/docs/puppet/5.5/types/file.html#file-attribute-mode

When specifying numeric permissions for directories, Puppet sets the search permission wherever the read permission is set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the test failures is due to the now excessive indentation of the parameters in this resource. The acceptance test failures seem to be related to the new modes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice: /Stage[main]/Main/Openvpn::Server[test_openvpn_server]/Openvpn::Ca[test_openvpn_server]/File[/etc/openvpn/test_openvpn_server/easy-rsa/keys/vpnclienta.key]/mode: mode changed '0600' to '0755'
https://travis-ci.org/voxpupuli/puppet-openvpn/jobs/458818494#L1619

group => 0,
source => "file:${openvpn::easyrsa_source}",
require => File["${etc_directory}/openvpn/${name}"],
Expand Down