Ensure compatibility with Splunk 9.2.0.1 and 9.0.0

[siegy22]

Pull Request (PR) description

Multiple fixes/improvements to ensure compatibility to install Splunk 9, due to Splunk 7 and 8 being EOL.

• Fix linux-2.6 in download URL for RPMs
• Stop installing net-tools starting with Splunk 8
• Fix/improve user handling.
• Test against multiple versions of Splunk. (7.2.4.2, 9.0.0, 9.2.0.1)
  Splunk 8 had some issues running inside the GitHub actions container: https://github.com/voxpupuli/puppet-splunk/actions/runs/8328266422/job/22787891637?pr=350#step:6:996 will tackle that in a separate PR.

This Pull Request (PR) fixes the following issues

Fixes #348

[luedderd]

@siegy22 can you retrigger the CI checks by either closing/reopening this PR or doing the following:

git commit -m "retrigger checks" --allow-empty
git push

#348 is blocking an upgrade deployment in my environment, I'd troubleshoot the failed checks here to help contribute towards a merge but the logs have since expired. Thanks!

[siegy22]

@luedderd I amended and force pushed, CI is running once again 😄

[luedderd]

I haven't worked with these kind of Puppet CI tests before but it seems they're failing in all current PRs for a different issue related to the seed admin password.

@kenyon @bastelfreak seem to be the most active approvers, is there anything else holding this from being approved/merged? Thanks in advance

[siegy22]

@luedderd I spent some hours debugging the GitHub actions. Finally found out what's the problem, I opened a separate PR: #356
After this is merged, we can probably rebase and go on here. 🎉

[siegy22]

@luedderd I rebased onto my other branch and also added tests.
As of now, you could set splunk::enterprise::enterprise_package_src to the full URL to make it work. E.g. https://download.splunk.com/products/splunk/releases/9.2.0/linux/splunk-9.2.0-1fff88043d5f.x86_64.rpm for 9.2.0

[bastelfreak]

With this change, is it still required that net-tools are explicitly installed?

puppet-splunk/manifests/forwarder/install.pp

Lines 64 to 70 in 069a142

	# Required for splunk 7.2.4.2
	if $splunk::params::manage_net_tools and $facts['kernel'] == 'Linux' and (versioncmp($splunk::forwarder::version, '7.2.4.2') >= 0) {
	stdlib::ensure_packages(['net-tools'], {
	'ensure' => 'present',
	})
	Package['net-tools'] -> Package[$splunk::forwarder::package_name]
	}

that's really legacy tooling and the rpm should depend on it if it's an actual dependency. Do we need to explicitly install it?

[siegy22]

@bastelfreak Didn't check that yet. It's possible that this is not needed anymore. But I'd down to check that in a separate branch/PR. We need to ensure that Splunk 9.x can be installed and upgraded. As of now, even 8.2 is EOL and thus we should probably set the focus to be 9.x compatible for the future.

This change just fixes the URL that is being generated to download splunk.

[bastelfreak]

We have acceptance tests at: https://github.com/voxpupuli/puppet-splunk/tree/master/spec/acceptance

can you add one with the new version so we can verify that it works?
If you don't know beaker: The tests are actual puppet code, executed in different docker containers. duplicate one of the existing blocks and add the correct version.

[siegy22]

There seems to be a issue unrelated to this change when installing 9.2.0.1. The package is downloaded and installed correctly (so this change is working) but the default parameters don't make sense with the newer versions.

I would suggest opening another PR to test the installation and upgrade of 9.x versions on all the platforms. I can do that.

[bastelfreak]

shouldn't that go into this PR as well? We currently don't support version 9 at all and this PR now implements it in parts, but it's not really usable because of the wrong parameters?

[kenyon]

net-tools is actually only required for the Splunk Add-on for Unix and Linux, which collects data on hosts where the splunk forwarder is installed, but I think this add-on is typically always installed on hosts where the forwarder is installed. The docs at https://docs.splunk.com/Documentation/AddOns/released/UnixLinux/Requirements say it's only needed on EL 7 and EL 8, but I wonder if that just hasn't been updated to include EL 9 also.

I wonder if we should just remove everything related to net-tools from this module and leave that up to the user, though.

Related: #308

[siegy22]

@kenyon I tried it before with a RHEL 9 instance, installing some 8.x versions and 9.x versions. No issues without having net-tools installed. The only version that didn't install that I tried was 7.2.4.2 that said net-tools needed to be installed. Maybe they included the "Splunk Add-on for Unix and Linux" before? But it's no longer relevant for 8.x and 9.x as far as I can tell.

[siegy22]

@bastelfreak @kenyon Can you review this?

[luedderd]

Thanks everyone for working on this! I've tested the forked module and it's worked so far on my handful of testing servers, as soon as this is merged/released I look forward to promoting it to the rest of my node inventory. 🎉