Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exception.pp #132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update exception.pp #132

wants to merge 4 commits into from

Conversation

ola-pt
Copy link

@ola-pt ola-pt commented Sep 10, 2022

To handle continual enforcement of certain attributes

Pull Request (PR) description

The following attributes will get enforced. If the puppet resource using the class doesn't exist it will have the rule added. If the rule exists then the following attributes will get checked(if they don't exist then the rule will get removed):

  • local port
  • remote port
  • protocol
  • description
  • & Remote IP (if the attribute isn't undefined)

This Pull Request (PR) fixes the following issues

Partially fixes the following issues:

To handle continual enforcement of ceratin attributes
Fixed class name
Puppet linter requested a space in two lines updated
@ola-pt
Copy link
Author

ola-pt commented Sep 10, 2022

The static linter fails due to Powershell variables used within the various attribute checks

@ola-pt
Copy link
Author

ola-pt commented Sep 10, 2022

Feel free to handle that as you will; maybe an ignore comment for the linter?

@bellegarde-c
Copy link

Not a voxpupuli dev but this may help for a merge request:

  • A better commit message
  • Only one commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants