Fix provider windowsfirewall #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the title of this pull request would be used in the changelog, could you come up with a better title that says something about the bug that is being fixed? |
ralfbosz
changed the title
The command Get-NetFirewallProfile shows the variable DisabledInterfaceAliases with curly brackets, causing every run to change this parameter. Delete the curly brackets from value to solve this.
|
Seems new checks are present, which have nothing to do with my PR. I hope my commit message is a bit better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
Get-NetFirewallProfileshows the variableDisabledInterfaceAliaseswith curly brackets, causing every run to change this parameter. Delete all curly brackets from value to solve this.Pull Request (PR) description
The output of
DisabledInterfaceAliasesgives curly brackets around the interface-name. Added a delete to the provider to delete these.This Pull Request (PR) fixes the following issues
Fixes #126