Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from mixed case to uppercase env vars #59

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Switch from mixed case to uppercase env vars #59

merged 1 commit into from
Sep 20, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak marked this pull request as ready for review May 30, 2023 12:43
@bastelfreak bastelfreak changed the title Switch from mixed case to upperacase env vars Switch from mixed case to uppercase env vars May 30, 2023
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed some:

$ rg 'BEAKER_[a-z]'
spec/spec_helper_acceptance_spec.rb
6:      before(:example) { ENV['BEAKER_provision'] = 'no' }

README.md
39:BEAKER_setfile=centos7-64 bundle exec rake beaker

@ekohl
Copy link
Member

ekohl commented Sep 20, 2023

Note to self: I checked that it was a feature in beaker-rspec 8.0.0 and that's the minimum version in the gemspec.

@ekohl ekohl merged commit b7f8f37 into master Sep 20, 2023
26 checks passed
@ekohl ekohl deleted the env branch September 20, 2023 10:17
@bastelfreak bastelfreak added the enhancement New feature or request label Sep 20, 2023
@@ -13,7 +13,7 @@ def configure_beaker(modules: :metadata, &block)

require_relative 'fixtures' if modules == :fixtures

unless ENV['BEAKER_provision'] == 'no'
unless ENV['BEAKER_PROVISION'] == 'no'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni pointed out this can be considered breaking. Let's fix it up and check for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants