Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use beaker-hiera 1.x with hiera.yaml version 5 #75

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 3, 2023

The beaker-hiera 1.x release updates the suite configuration to version 5. This avoids a deprecation warning and Puppet 8 reportedly also dropped version 3.

Technically this would be a breaking change, but I have a feeling that overriding the hierachy is used very little.

@ekohl
Copy link
Member Author

ekohl commented Nov 3, 2023

Depends on voxpupuli/beaker-hiera#17.

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is fine. Hiera 3 is dead long enough to justify a breaking change

@ekohl
Copy link
Member Author

ekohl commented Nov 3, 2023

Looks successful in theforeman/puppet-pulpcore#312 so marking as ready.

@ekohl ekohl marked this pull request as ready for review November 3, 2023 22:09
The beaker-hiera 1.x release updates the suite configuration to version
5. This avoids a deprecation warning and Puppet 8 reportedly also
dropped version 3.

This also changes the hierarchy from os/$family to family/$family. This
is important to distinguish RedHat, which can be both an OS and a
family.
@bastelfreak bastelfreak merged commit e6375b9 into voxpupuli:master Nov 21, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants