[WIP] Update the release procedure #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on code by @bastelfreak
ekohl
commented
Dec 18, 2017
|
|
||
| version = args[:version] | ||
| if ['major', 'minor', 'patch'].include?(version) | ||
| bump_task = "module:bump:#{version}" |
There was a problem hiding this comment.
Patch will need special treatment: Bumping version from 2.0.1-rc0 to 2.0.2
There was a problem hiding this comment.
What about allowing users to specify a specific version as well?
There was a problem hiding this comment.
That should be supported in the elsif clause
There was a problem hiding this comment.
voxpupuli/puppet-blacksmith#62 should handle the bumping issue.
|
The additional commits move the changelog task from modulesync to this gem. It also updates docs and simplifies the travis_release. |
ekohl
commented
Dec 18, 2017
| end | ||
|
|
||
| Rake::Task[bump_task].invoke | ||
| Rake::Task['changelog'].invoke |
There was a problem hiding this comment.
This doesn't work. The future version is read when the Rakefile is loaded, then bumped at runtime but not re-read.
|
ping @ekohl :) How should we proceed here? |
|
@ekohl ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code by @bastelfreak in voxpupuli/modulesync_config#397 (comment)
This should codify what we are doing in practice.