switch to stringified facts; use rspec-puppet-facts 3 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bastelfreak
commented
May 24, 2024
•
bastelfreak
commented
- depends on work with symbolized strings rspec-puppet-facts#175
- tested at voxpupuli-test: test stringified facts puppet-example#54
- contains Use our spec_helper for tests #133 (but we could drop that if we don't like it)
- alternative to require rspec-puppet-facts 5.x; drop legacy facts support #132
Previously our tests didn't honour our spec/spec_helper.rb. This configures some rspec defaults for our Puppet modules. It makes sense that our tests use the same settings. This revealed some problems in other PRs: voxpupuli#125
rwaffen
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.