Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec-puppet: Require 5.x #146

Merged
merged 1 commit into from
Sep 6, 2024
Merged

rspec-puppet: Require 5.x #146

merged 1 commit into from
Sep 6, 2024

Conversation

bastelfreak
Copy link
Member

This release fixes the annoying warnings we saw a lot:

Could not retrieve fact ipaddress...
``

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 6, 2024
bastelfreak added a commit to bastelfreak/puppet-example that referenced this pull request Sep 6, 2024
@bastelfreak
Copy link
Member Author

This requires puppetlabs/puppetlabs_spec_helper#470

@bastelfreak bastelfreak changed the title rspec-puppet: Require 5.x rspec-puppet: Require 5.x & puppetlabs_spec_helper: Require 8.x Sep 6, 2024
This release fixes the annoying warnings we saw a lot:

```
Could not retrieve fact ipaddress...
``
@TheMeier TheMeier self-requested a review September 6, 2024 10:53
@TheMeier
Copy link

TheMeier commented Sep 6, 2024

Do we need a backward-incompatible label here?

@bastelfreak
Copy link
Member Author

I don't think so. This doesn't break anything for us.

@bastelfreak bastelfreak changed the title rspec-puppet: Require 5.x & puppetlabs_spec_helper: Require 8.x rspec-puppet: Require 5.x Sep 6, 2024
@bastelfreak bastelfreak merged commit e1efb5a into voxpupuli:master Sep 6, 2024
10 checks passed
@bastelfreak bastelfreak deleted the rp5 branch September 6, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants