Add puppet-lint-spaceship_operator_without_tag-check #25
Conversation
I tested this for my own modules already, also heavily used in the foreman ecosystem.
|
I do this fairly often though... |
|
Are there any uses you can find where we should change the code and not just disable the plugin with control comments? |
|
I've recently also been wondering. The alternative often isn't better. I think the alternative here is autorequire in the type. Not sure about autonotify though. |
|
If the plugin could be configured to just check for gross misuse like |
That only works for native (not defined) types though. |
and presumably all the negatives the plugin is trying to avoid (realisation of virtual resources), still apply if the type uses autorequire?? |
|
In my nrpe module i have the plugin define include the main class and require a directory, which requires the nrpe package. Which is a long way of saying, we can and should refactor these. +1 for adding this lint plugin. Seems that these are all using the non-idempotent terminology and horrible pattern of ::install, ::config, ::service. We shouldn't be using that and by moving away from it, we will not need all this spaceship nonsense. https://github.com/ghoneycutt/puppet-module-nrpe/blob/master/manifests/plugin.pp |
I tested this for my own modules already, also heavily used in the
foreman ecosystem.