Skip to content

Commit

Permalink
adding webpack-dev-server as dev dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
@vpowers
vpowers committed Nov 22, 2016
1 parent 8043d77 commit 39a6ce4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"webworkify-webpack-dropin": "^1.1.9"
},
"devDependencies": {
"webpack": "^1.13.3"
"webpack": "^1.13.3",
"webpack-dev-server": "^1.16.2"
}
}

6 comments on commit 39a6ce4

@AdamTyler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpowers did you ever get this working properly?

@vpowers
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamTyler Yes, this project was to just demonstrate how to get video.js hls working when using webpack. Are you having issues?

@AdamTyler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I should've left this comment on another thread. It was in reference to the issues you were seeing in getting webpack and hls plugin to play nice in your nwb project. Reading this made it seem like they offered an idea for what the issue is but I still haven't solved it

@vpowers
Copy link
Owner Author

@vpowers vpowers commented on 39a6ce4 Nov 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after some long and arduous debugging, I was able to write something that is compatible with nwb. I plan on updating the other thread with my solution. The issue is that the videojs-contrib-hls has a dependency that is specific to how browserify packages code. The hls team acknowledges the issue here They provide a solution for a pure webpack project but doesn't work with nwb since there are some differences, as noted in the thread you linked to. My code is in a private repo but I can add it to my public account. I'll try and do that later today.

@AdamTyler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch. I look forward to checking it out

@vpowers
Copy link
Owner Author

@vpowers vpowers commented on 39a6ce4 Nov 30, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamTyler I have added the forked repo to support webworkify when using nwb here. You can see an example usage in a react app here.

Please sign in to comment.