Adding other KAN layers

[armbrusl]

I have implemented the following two layers

Julia implementation of FourierKAN
Julia implementation of ChebyKAN

I also added another test for all the layers. Not sure how most of GitHub works so let me know if there is anything else I should do.

[vpuri3]

Thanks @armbrusl, the code looks ok. Can you

• take a look at the comments
• update the README code to include the new layers

[vpuri3]

just pushed a commit to master with all the Lux 0.x --> 1.x fixes. @armbrusl I also rebased this branch to master. I removed all the unnecessary packages in test/Project.toml (e.g., LLVM, Debugger, etc). They should not be added to the pull request. You should do a git fetch && git pull on your machine before proceeding. You should also update your Julia environment.

Can you also move the test you added in test/runtests.jl to a separate file.

[armbrusl]

I think I have addressed your suggestions. Thanks for walking me through it! Let me know if there is anything else I need to do. The only thing I haven't done is edit the README file, is there anything specific I should add ?

[vpuri3]

see above comments

[vpuri3]

Can you not use NNlib.batched_mul or NNlib.batched_vec for this?

[vpuri3]

https://fluxml.ai/NNlib.jl/dev/reference/#NNlib.batched_mul

[armbrusl]

I am not sure. I have been trying but I have not able to get it right

[vpuri3]

Can you add the new layers to the code in the README and report timings?

https://github.com/vpuri3/KolmogorovArnold.jl/blob/master/README.md?plain=1#L14-L88

If not, I can do it after this is merged.

[vpuri3]

See workflow error: https://github.com/vpuri3/KolmogorovArnold.jl/actions/runs/11579597184/job/32236568354?pr=3#step:6:545

[vpuri3]

@armbrusl can you investigate this error? I am not seeing it in master with 1.10 or 1.11. I also updated master to only test on 1.10 and 1.11. If you rebase this branch, then that change will be incorporated.

[armbrusl]

@vpuri3 I am not able to replicate the errors, when I run the required command

import Pkg; Pkg.test(;coverage=true, julia_args=["--check-bounds=yes", "--compiled-modules=yes"], force_latest_compatible_version=false, allow_reresolve=true)

everything works fine. I also rebased the branch.

[vpuri3]

@armbrusl i tested the CI on Master in #4 and it is fine. The failures here are due to changes introduced in this pr

I also don't see your rebase commits. Make sure you git checkout master, git fetch and git pull the latest version. then checkout this branch again and git merge master. and then do a git push

[armbrusl]

I think I have done the steps you told me, how will I know if I have done it right

[vpuri3]

I'll check out this branch and investigate this evening

[vpuri3]

@armbrusl you haven't rebased correctly. Look at this branch. This branch is some commits behind. You need to rebase this branch to the latest master.