Fix typing issues

vsakkas · Jul 6, 2024 · f84f2b6 · f84f2b6
1 parent 6b7b3e6
commit f84f2b6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/django_base_settings/django_base_settings.py b/django_base_settings/django_base_settings.py
@@ -3,14 +3,17 @@
 from pydantic import BaseModel as _BaseModel
 from pydantic import ConfigDict
 from pydantic_settings import BaseSettings as _BaseSettings
+from pydantic_settings import SettingsConfigDict
 
 
 class BaseModel(_BaseModel):
     model_config = ConfigDict(alias_generator=lambda field_name: field_name.upper())
 
 
 class BaseSettings(_BaseSettings):
-    model_config = ConfigDict(alias_generator=lambda field_name: field_name.upper())
+    model_config = SettingsConfigDict(
+        alias_generator=lambda field_name: field_name.upper()
+    )
 
 
 class DjangoBaseSettings(BaseSettings):
@@ -53,7 +56,9 @@ def __init__(self) -> None:
     def _inject_settings(self, module, settings: BaseSettings) -> None:
         for field_name, field_value in settings.model_dump(by_alias=True).items():
             # For nested models, inject a dictionary representation
-            if isinstance(field_value, (BaseSettings, BaseModel)):
+            if isinstance(
+                field_value, (BaseSettings, BaseModel, _BaseSettings, _BaseModel)
+            ):
                 setattr(
                     module,
                     field_name,