Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validateTxProof and move to contract template #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Pl8tinium
Copy link
Collaborator

adds validateTxProof

and

moves the sdk to the contract template repo so we can implement tests


btw i think we should find a good way to regularly upstream changes from the contract template repo, maybe with github actions and automatic pull request creation? (for all our contract template deriving repos eg btc relay). Maybe smth like this can be useful

https://github.com/tgymnich/fork-sync


tests dont work, yet

it wants to import the module sdk, but as we are in the actual sdk we may have some circular dependency problem going on here and need to provide some workaround for this specific repo

problem is probably tied to the sdk mock injection for the tests

i tried to play a bit with the asconfig, without success

[user] sdk (feature/addValidateTxProof) > npm run test

> @vsc.eco/[email protected] test
> node --experimental-vm-modules ./node_modules/jest/bin/jest.js

(node:7008) ExperimentalWarning: VM Modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
 FAIL  tests/index.ts
  TBD
    ✕ TBD (4 ms)

  ● TBD › TBD

    Cannot find module 'sdk' from 'build/debug.js'

      at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:427:11)
          at async Promise.all (index 0)

tried to merge everything as reasonable as possible, docs and release process shouldnt have any noticable changes

@Geo25rey wont ping u on discord when its not time critical, ait?

package-lock.json Outdated Show resolved Hide resolved
export * from './index'
Copy link
Member

@Geo25rey Geo25rey May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for the @external calls when testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants