-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validateTxProof and move to contract template #1
Open
Pl8tinium
wants to merge
8
commits into
master
Choose a base branch
from
feature/addValidateTxProof
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geo25rey
reviewed
May 29, 2024
export * from './index' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work for the @external
calls when testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds validateTxProof
and
moves the sdk to the contract template repo so we can implement tests
btw i think we should find a good way to regularly upstream changes from the contract template repo, maybe with github actions and automatic pull request creation? (for all our contract template deriving repos eg btc relay). Maybe smth like this can be useful
https://github.com/tgymnich/fork-sync
tests dont work, yet
it wants to import the module sdk, but as we are in the actual sdk we may have some circular dependency problem going on here and need to provide some workaround for this specific repo
problem is probably tied to the sdk mock injection for the tests
i tried to play a bit with the asconfig, without success
tried to merge everything as reasonable as possible, docs and release process shouldnt have any noticable changes
@Geo25rey wont ping u on discord when its not time critical, ait?