Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to allow setting a custom configuration for keycloak #197

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add feature to allow setting a custom configuration for keycloak #197

merged 1 commit into from
Jul 22, 2024

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Jul 16, 2024 •
edited
Loading

Summary

  • This PR adds support for adding a custom Keycloak configuration

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee added the enhancement New feature or request label Jul 17, 2024
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team July 17, 2024 20:52
@TheBigLee TheBigLee requested a review from zugao July 18, 2024 08:24
wejdross
wejdross approved these changes Jul 18, 2024
View reviewed changes
apis/vshn/v1/dbaas_vshn_keycloak.go Outdated Show resolved Hide resolved
pkg/comp-functions/functions/vshnkeycloak/deploy.go Outdated Show resolved Hide resolved
Kidswiss
Kidswiss requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing

apis/vshn/v1/dbaas_vshn_keycloak.go Outdated Show resolved Hide resolved
zugao
zugao approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging figure out with Inventage to use a secret or cm.

@TheBigLee TheBigLee force-pushed the keycloak/config branch 2 times, most recently from 596158d to 634f776 Compare July 19, 2024 13:22
zugao
zugao approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, rest looks good. Please test this in lab carefully, for a new instance and for an existing instance by deleting or adding configuration configMap/secret.

apis/vshn/v1/dbaas_vshn_keycloak.go Outdated Show resolved Hide resolved
@TheBigLee TheBigLee merged commit fbe36c8 into master Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

@wejdross wejdross Awaiting requested review from wejdross

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheBigLee @Kidswiss @wejdross @zugao