Fix a bug, where you can't edit an existing VSHNPostgreSQL instance #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
requested review from
a team,
Kidswiss,
wejdross and
zugao
and removed request for
a team
There is currently a bug in the AddConnectionDetails function that takes the SGcluster from the `observed` rather then the `desired` state. Since this function is run *after* the `DeployPostgreSQL` function and takes the cluster configuration from the `observed` state and at the end writes it to the `desired` state, it will effectively override every change done to the `SGCluster` object in the `DeployPostgreSQL` function. The function should rather get the `SGCluster` object from the desired stage to avoid this issue. Signed-off-by: Nicolas Bigler <[email protected]>
Kidswiss
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is currently a bug in the AddConnectionDetails function that takes the SGcluster from the
observedrather then thedesiredstate. Since this function is run after theDeployPostgreSQLfunction and takes the cluster configuration from theobservedstate and at the end writes it to thedesiredstate, it will effectively override every change done to theSGClusterobject in theDeployPostgreSQLfunction.The function should rather get the
SGClusterobject from the desired stage to avoid this issue.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog