Fix connection detail name #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the claim-name contains `nextcloud` it will not append `nextcloud` to the `fullName` variable in the helm chart. However if the claim-name doesn't contain `nextcloud`, then the `fullName` will get a `-nextcloud` appendix, resulting in broken service names.
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
zugao
approved these changes
Jul 22, 2024
wejdross
approved these changes
Jul 23, 2024
For Minio this has already been mitigated, but maybe Redis is affected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the claim-name contains
nextcloudit will not appendnextcloudto thefullNamevariable in the helm chart.However if the claim-name doesn't contain
nextcloud, then thefullNamewill get a-nextcloudappendix, resulting in broken service names.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog