Fix bucket naming clashes for cloudscale and exoscale #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
force-pushed
the
fix/bucket_name_clashes
branch
3 times, most recently
from
7da789a
to
6e12f94
Compare
If a nested services needed more than one bucket, the provisioning would fail. That's because the bucket CRs for cloudscale and exoscale patched value of the `crossplane.io/composite` label to the `metadata.name` of the resulting objects. As this will always be the name of the top most composite, there were name clashes. This change is implemented in a backward compatible fashion. If there are already existing CRs, it will simply take their name. If the CRs are freshly created, the new naming will be used. Also the naming follows what has been implement for the minio buckets. It takes the value of the `bucketName` as the name of the CRs. As bucket names should be unique per provider anyway.
Kidswiss
force-pushed
the
fix/bucket_name_clashes
branch
from
6e12f94
to
dcab5ed
Compare
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
TheBigLee
reviewed
Aug 5, 2024
pkg/comp-functions/functions/buckets/cloudscalebucket/cloudscalebucket.go
Show resolved
Hide resolved
pkg/comp-functions/functions/buckets/cloudscalebucket/cloudscalebucket.go
Show resolved
Hide resolved
TheBigLee
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a nested services needed more than one bucket, the provisioning would fail. That's because the bucket CRs for cloudscale and exoscale patched value of the
crossplane.io/compositelabel to themetadata.nameof the resulting objects. As this will always be the name of the top most composite, there were name clashes.This change is implemented in a backward compatible fashion. If there are already existing CRs, it will simply take their name. If the CRs are freshly created, the new naming will be used.
Also the naming follows what has been implement for the minio buckets. It takes the value of the
bucketNameas the name of the CRs. As bucket names should be unique per provider anyway.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog