Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis Backup Listing #26

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add Redis Backup Listing #26

merged 1 commit into from
Jun 26, 2023

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jun 20, 2023 •
edited
Loading

Summary

It's now possible to list the backups of Redis instances via the API server.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss marked this pull request as draft June 20, 2023 09:37
@Kidswiss Kidswiss added the enhancement New feature or request label Jun 23, 2023
@Kidswiss Kidswiss marked this pull request as ready for review June 23, 2023 13:41
@Kidswiss Kidswiss requested review from a team, glrf and wejdross and removed request for a team June 23, 2023 13:41
wejdross
wejdross approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is clean
accidently, but tested it on lab today while debugging other issue with You
approve from my side

glrf
glrf suggested changes Jun 23, 2023
View reviewed changes
pkg/apiserver/vshn/redis/backup.go Outdated Show resolved Hide resolved
pkg/apiserver/vshn/redis/get.go Outdated Show resolved Hide resolved
pkg/apiserver/vshn/redis/list.go Outdated Show resolved Hide resolved
pkg/apiserver/vshn/redis/get.go Outdated Show resolved Hide resolved
pkg/apiserver/vshn/redis/watch.go Show resolved Hide resolved
pkg/apiserver/vshn/redis/watch.go Outdated Show resolved Hide resolved
@Kidswiss Kidswiss force-pushed the add/redisbackup_listing branch 4 times, most recently from ae1bc9b to cadc97e Compare June 26, 2023 08:36
@Kidswiss
Add Redis backup listing
3a9e61e 
It's now possible to list the backups of Redis instances via the API
server.
@Kidswiss Kidswiss requested a review from glrf June 26, 2023 08:46
@Kidswiss Kidswiss merged commit 1c4818a into master Jun 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

@wejdross wejdross wejdross approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kidswiss @glrf @wejdross